anorth/agent-skills

deep-review

Deep, themed review of a diff: the review-diff flow and its standard lenses, plus one cheap reviewer subagent per theme, using distinctive preferences distilled from Alex North's public GitHub reviews (naming, API shape, errors, tests, coupling, and related…

Quelltext ansehen

Verwendung

  1. Installationsbefehl kopieren und das Quellpaket vor der Installation in der eigenen Agentenumgebung prüfen.
  2. Benötigte Werkzeuge, Zugangsdaten und Hosts im Original prüfen.
  3. Eingabe und gewünschtes Ergebnis beschreiben und die Ausgabe mit den Quellen abgleichen.
npx skills add https://github.com/anorth/agent-skills --skill deep-review

Vor dem Start

  • Die Installation umfasst weder Modellabo noch API-Kontingent oder Dateizugriffsrechte.
  • Sterne und Installationen zeigen Aktivität, keine unabhängige Qualitäts- oder Sicherheitsprüfung.
Originales Skill-Dokument

Aus dem Quell-Repository gerendert; Überschriften, Beispiele, Code, Tabellen, Links und Bilder bleiben erhalten.

Deep review

Run the /review-diff skill's flow with a bigger lens set. If review-diff isn't available, tell the user and stop.

At its Lenses step, read the change set and decide which themes below are relevant. The lens set is:

  • review-diff's standard lenses, on the strong tier, by their absolute paths in review-diff's directory;
  • each theme under Always, and each theme under When the diff matches that fits the diff,

on the cheap tier. Pass the theme file's absolute path as the lens.

Everything else follows review-diff: models, launch, check, triage, fix, and report. Theme reviewers on the cheap tier are noisy, so the check step matters most for them.

Always

  • `Naming` — identifiers
  • `Style` — dead weight, constants, order, locality
  • `Comments` — comments, docs, stale nearby comments

When the diff matches

  • `API Shape` — public functions, types, endpoints, events, persisted formats
  • `Architecture` — modules, layers, where state or effects live
  • `Change Scope` — mixed features, refactors, or cleanups in one PR
  • `Concurrency` — shared mutable state, threads/coroutines, timers
  • `Coupling` — module boundaries, wiring, cross-component APIs
  • `Dependencies` — manifests, lockfiles, vendored or generated code, new libraries
  • `CI locally` — CI, build, lint, or codegen steps
  • `Errors` — new or changed failure paths, error types, panics
  • `Invariants` — validation, state transitions, persistence, aggregates
  • `Observability` — logs, metrics, journals, or swallowed failures
  • `Tests` — tests, fixtures, doubles, or test helpers
aus demselben Repository

Weitere Skills

Alle Skills