bsene/skills

review

Reviews current branch changes: reads the actual diff, produces structured feedback (Blockers / Concerns / Nits), asks targeted questions, then applies fixes on approval.

Voir la source
Document Skill original

Rendu depuis le dépôt source en conservant titres, exemples, code, tableaux, liens et images.

/review

Workflow

  1. Run git diff main...HEAD — get ACTUAL diff, never reconstruct
  2. Produce structured review (severity tiers below)
  3. Ask ≤5 grill-me questions — one per key design decision; design intent only, not style
  4. On approval: apply Blocker fixes → run tests → run lint → commit (conventional message)

Scope Discipline

Review only what changed on this branch — never pre-existing, unmodified code. The diff is the contract; default to git diff main...HEAD, not memory or full-file reads. Real repos make this a hard rule:

Focus exclusively on changes introduced in the current branch compared to main. Do not review pre-existing code that was not modified.

Security-Before-Push

For anything about to be pushed, run a security-focused review of the branch's own changes before shipping (optional trivy fs on vulnerable deps). Watch specifically for: logged secrets/tokens/PINs/PII, and __proto__/prototype-walking reads on untrusted config.

Agent-Authored Diffs

If the branch was authored largely by an agent — or you suspect it was — layer agentic-code-review. Watch first for the three characteristic agent failure modes, all Blockers: test tampering (assertions edited to match broken behavior — read test diffs before the code), CI weakening (removed or skipped tests, lowered gates), and prompt injection (untrusted input reaching LLM calls in new AI features). Tier review depth by blast radius, not by author; the human who clicks merge owns the change.

Severity Tiers

TierCriterionRequired Action
BlockerBug, security hole, data loss, broken invariantFix before merge
ConcernDesign flaw, missing test, perf issueDiscuss + likely fix
NitStyle, naming, minor duplicationOptional

Output Format

## Blockers
- `src/auth.ts:42` — expiry check uses `<` not `<=`; off-by-one passes expired tokens

## Concerns
- No test for error path in `processPayment()`

## Nits
- `userData` → `user` (same meaning, shorter)

## Questions
1. Why is `retryCount` hardcoded to 3 — should this be config?

Deep-Rigor Mode

When the user asks for a strict / thorough review (e.g. "/review --strict", "deep review", "rigorous review", "code quality audit"), layer the code-review-and-quality rubric on top of the workflow above: walk the five axes (correctness, readability, architecture, security, performance), promote its presumptive blockers into Blockers, and hold commits to its higher approval bar. For agent-authored branches, also layer agentic-code-review.

Related

(Standards + Spec vs the originating issue) run as parallel sub-agents. Source: <https://github.com/mattpocock/skills/tree/main/skills/engineering/code-review>

upstream of the vendored deep-rigor rubric used in Deep-Rigor Mode above; see also agentic code review for the agent-diff failure modes.

Benchmark

Scenario: .benchmarks/scenarios/review-001-severity-tiers.md · Run: 2026-08-31 · Log: .benchmarks/runs/2026-08-31/review-001-severity-tiers.json

ModelWithoutWithDelta
claude-opus-4-867%83%+16%
claude-sonnet-4-683%67%−16%
claude-haiku-4-583%83%+0%
NEG (run 2026-08-31). Sonnet −16 on the severity-tier boundary; opus +16. Classification ambiguous between criteria and tier table — diagnostic c5-only re-run queued before any edit (cap reached). Gate per .agents/skills/skill-optimizer/rules/release-gates.md.
du même dépôt

Autres Skills

Tous les Skills
bsene
Communauté

c4-diagram

Generates C4 model architecture diagrams using Structurizr DSL (primary) or Mermaid C4 (fallback). Use when: user asks to "draw a diagram", "create a C4 diagram", "show architecture as a diagram", "generate architecture diagram", "document the system". DO NOT USE for code explanation or walkthroughs (use explain-code), class/sequence/ER diagrams (C4 is system-architecture only), or when a diagram is incidental to a code change — only when a C4 diagram is the primary deliverable.

installations
1
GitHub Stars
5
Mis à jour
21 sept.
bsene
Communauté

clean-code

Use when writing new code, naming modules/files/functions/classes/variables, reviewing or refactoring code for readability, assessing/reducing complexity, deciding whether an abstraction belongs, or reviewing with CUPID. For behavior-preserving refactors within a function, class, or file, route to the refactoring/ sub-skill. Trigger on requests like "name this function", "is this a good variable name", "review this for clean code", "reduce complexity", "should I add a comment here", "should I abstract this", "review with CUPID", "code smell", "extract method", or "refactor this class". Covers human-scale design, naming, complexity budgets, comments, CUPID, and in-place refactoring. Pairs with language-specific skills (typescript, go, clojurescript) for syntax/idiom concerns.

installations
1
GitHub Stars
5
Mis à jour
21 sept.
bsene
Communauté

clojurescript

Write, review, debug, and configure ClojureScript code and projects. Use this whenever the user mentions ClojureScript, .cljs/.cljc files, shadow-cljs, figwheel, the CLJS compiler, JS interop from Clojure, Reagent/re-frame/Reagent-style UI code, or asks to convert JS/TS logic into ClojureScript. Also use it for questions about CLJS compiler options (:optimizations, :main, :npm-deps, :externs, etc.), consuming JS/npm libraries from CLJS, source maps, Google Closure Library usage, or the newer ^:async/await function support. Also trigger for CLJS recursion/stack-overflow/trampoline questions. Trigger even if the user just pastes CLJS code with an error and asks "what's wrong here" or asks to set up a new CLJS project. Do NOT use for nbb (babashka/nbb) scripts, nbb.edn projects, or anything meant to run via nbb script.cljs/npx nbb — those have a different (SCI-interpreted, no-Closure-Compiler) language surface; those are out of scope for this skill — consult nbb's own documentation.

installations
1
GitHub Stars
5
Mis à jour
21 sept.
bsene
Communauté

communication

Analyze a real communication artifact (Slack/Teams message, email, meeting transcript, pitch or presentation draft, CV, or resume) and coach it sharper using seven rhetoric + structure techniques: ethos/logos/pathos, reframing tough questions, centering the other person, the Pyramid Principle, pattern interrupt, making ideas feel safe, and the cognitive-load through-line. Diagnose what works, what's missing, then rewrite. TRIGGER when: user wants to improve communication, "review my email/Slack/CV", "analyze this transcript", prep for a meeting/pitch/presentation, "how do I say this", be more persuasive/assertive, handle a tough question, talk to execs, "is this too long-winded". Also trigger for author style presets under references/authors/: DHH (blunt/direct), Uncle Bob (defend a quality/testing standard), Jessitron (reflective systems-thinking essay), Martin Fowler (measured mixed-feelings stance). DO NOT USE for raw text generation with no analysis, marketing/copywriting, translation, or code/docs.

installations
1
GitHub Stars
5
Mis à jour
21 sept.