ammuench/ammuench_skills

review-guide

Review a pull request or branch diff for bugs, risks, and gaps, and provide a concise walkthrough guide for engineer triage.

ソースを見る

使い方

  1. インストールコマンドをコピーし、自分の環境へ導入する前にソースを確認します。
  2. 必要なツール、認証情報、対応環境を原文で確認します。
  3. 入力と成果物を指定し、出力を資料と照合します。
npx skills add https://github.com/ammuench/ammuench_skills --skill review-guide

開始前の確認

  • 導入にはモデル契約、API枠、ファイルへのアクセス許可は含まれません。
  • スター数や導入数は活動の指標であり、独立した品質・安全性試験ではありません。
リポジトリの原文

見出し、例、コード、表、リンク、参照画像を含む原文を表示しています。

review-guide

When to use

Use when the user asks for a code review of a remote pull request link or local branch changes versus the default branch.

Instructions

  1. Get the diff:
  • If PR link provided: fetch remote diff + existing PR comments. If fetch fails (auth, network, bad link), STOP and ask user to unblock.
  • If no link: diff current branch against default branch (usually main, sometimes develop or master). Ask if unclear.
  1. If the PR references a ticket (Jira, Linear, GitHub issue), fetch it for context. If none, proceed.
  2. Review only changed lines plus direct impacts. For each finding, give filepath:line_number. Use Conventional Comments format (see https://conventionalcomments.org/): labels praise:, nitpick:, suggestion:, issue:, question: with decorations (blocking), (non-blocking), (if-minor) to signal merge impact. Cover bugs, logic, architecture, testing gaps, AC mismatch, security, and so on.
  3. Verdict: Approve = non-blocking comments only. Comment = needs clarification but don't block for churn. Request Changes = blocking bug or harmful pattern. When in doubt, favor Request Changes.
  4. Provide a guide: group related files in logical read order (feature before tests), explain what each group does and what to focus on.
  5. Render both artifacts directly in chat concisely: short sentences, bullets/lists, ASD-STE100 plain language. No paragraphs unless necessary. Do not create files unless the user explicitly requests file output.