gjkim42/kanon-repo

finish-pr

Finish a PR by repeatedly requesting a Kelos review, waiting for its check, addressing valid review findings, squashing commits, and updating the PR until a review approves and that iteration is finalized.

ソースを見る

使い方

  1. インストールコマンドをコピーし、自分の環境へ導入する前にソースを確認します。
  2. 必要なツール、認証情報、対応環境を原文で確認します。
  3. 入力と成果物を指定し、出力を資料と照合します。
npx skills add https://github.com/gjkim42/kanon-repo --skill finish-pr

開始前の確認

  • 導入にはモデル契約、API枠、ファイルへのアクセス許可は含まれません。
  • スター数や導入数は活動の指標であり、独立した品質・安全性試験ではありません。
リポジトリの原文

見出し、例、コード、表、リンク、参照画像を含む原文を表示しています。

Finish PR

Repeat the following loop until a Kelos review approves, then complete that iteration before breaking. An approving verdict must still go through findings, squashing, pushing, and PR updates. Use gh for GitHub operations. This workflow updates the PR; it does not merge it.

Establish the target

Resolve the requested PR, or the current branch's PR when none is specified. Identify its repository, number, base branch, head branch, and head SHA. Work on that head branch and preserve unrelated local changes. Publish any intended pending changes before requesting a review so the reviewer sees them.

Review loop

  1. Request a review. Record the current remote head SHA, existing review

check IDs, and review comment timestamps. Post exactly /kelos review with gh pr comment <number> --repo <owner/repo> --body '/kelos review'.

  1. Wait for this review. Discover the Kelos review check created for this

request on the recorded SHA, and poll that check until it completes. Wait for it to appear even if older checks have already passed; do not post duplicate requests while waiting. Keep the user informed during the wait. If the head changes during the review, reconcile it before starting another iteration; that result cannot approve a different head.

  1. Read and address the findings. Read the fresh Kelos result and all PR

reviews, inline threads, and review comments. Kelos may publish an APPROVE verdict in an updated sticky comment rather than a GitHub APPROVED review. A successful check means the review task completed, not that it approved the PR. Require a result attributable to this request and recorded head. Use address-pr-review to verify findings and fix only those that are valid, current, and required. Check each finding's author, timestamp, head, and thread resolution; explicitly triage findings that do not warrant a change. Run the project's appropriate validation for any fixes.

  1. Squash and update the PR. Squash the PR branch's commits into one commit

above its merge base with the PR base, including any fixes. If it is already one commit and there are no changes, leave the commit intact. Preserve the complete intended diff and push to the PR's head branch, using an explicit --force-with-lease=<head-ref>:<expected-remote-sha> when rewriting history. If the lease fails, reconcile the remote changes before retrying. Update the PR title and description to describe the final implementation and validation, following the repository's PR template when present.

  1. Decide whether to repeat. Break only if this iteration's Kelos verdict

approves the recorded review head, steps 3 and 4 are complete, and no valid required findings remain. Break even if addressing findings or squashing in this iteration changed the pushed SHA; do not request another review solely to approve the resulting commit. Otherwise continue the loop.

Stop and report the blocker if the review check fails, is cancelled, cannot run, or completes without a usable verdict, or if repeated iterations cannot make progress on the same unresolved finding. Do not spin on failed tooling or silently treat a blocked review as approval.

On success, report the PR link, final commit, approval result, and validation. If finalization changed the SHA, identify the reviewed commit separately from the final pushed commit.

同じリポジトリから

関連する Skills

すべての Skills
gjkim42
コミュニティ

address-pr-review

Review the comments on a PR and address the findings that are valid and required. Use when the user says "address-pr-review", asks to address the PR review, handle or apply the review comments or review feedback on a PR, or fix what the reviewers asked for. Defaults to the PR for the current branch when none is named. This skill changes code; it is not a review pass.

1時間の導入数
4
GitHub Stars
0
更新日
10月31日
gjkim42
コミュニティ

api-review

Review the current Kelos branch, or an explicitly specified PR, issue, or diff, for Kubernetes API and CRD design quality. Use when asked for a Kelos API review, CRD/API compatibility review, Kubernetes API convention review, or review of changes under api/, generated CRDs, examples/, or self-development/ manifests. Default to the current branch when no target is specified. This skill is review-only.

1時間の導入数
4
GitHub Stars
0
更新日
10月31日
gjkim42
コミュニティ

design-cleanup

Sweep the current branch for leftovers of an abandoned design after a significant mid-work decision change, and rewrite the affected code, comments, tests, and docs so the result reads as if it had been designed this way from the beginning. Use when the user says "design cleanup", "clean up the old approach", "erase the journey", says a design decision changed and asks to clean up after it, or after a pivot in approach mid-branch. This is a rewrite pass over the code touched by the decision only

1時間の導入数
4
GitHub Stars
0
更新日
10月31日
gjkim42
コミュニティ

gjkim-instruction

Create and maintain gjkiminstruction.md, the root document for a loop-engineering effort. The document holds only the minimum requirements and confirmed decisions, and deliberately leaves everything else open so that later iterations are not locked into early guesses. Use whenever the user mentions gjkiminstruction.md, a root document or root doc for a loop, loop engineering, starting a long-running agent loop on a goal, or asks to record a requirement or a confirmed decision for such an effort.

1時間の導入数
4
GitHub Stars
0
更新日
10月31日