mralaminahamed/wp-dev-skills

wp-ci-qa

Use when a pull request has QA failures, a \"Testing Failed\" label, or QA comments reporting broken features — reading QA feedback and PR comments, tracing root cause using root-cause-patterns.md, applying scoped conventional-commit fixes, swapping labels…

ソースを見る

使い方

  1. インストールコマンドをコピーし、自分の環境へ導入する前にソースを確認します。
  2. 必要なツール、認証情報、対応環境を原文で確認します。
  3. 入力と成果物を指定し、出力を資料と照合します。
npx skills add https://github.com/mralaminahamed/wp-dev-skills --skill wp-ci-qa

開始前の確認

  • 導入にはモデル契約、API枠、ファイルへのアクセス許可は含まれません。
  • スター数や導入数は活動の指標であり、独立した品質・安全性試験ではありません。
リポジトリの原文

見出し、例、コード、表、リンク、参照画像を含む原文を表示しています。

Fix PR QA Failures

Model note: This skill traces non-obvious root causes across PHP, JS, and CI — run on sonnet or opus. Do not downgrade to haiku; cause identification requires reasoning across multiple files.

When to use

  • "QA marked my PR as Testing Failed", "fix the bugs in QA comments", "address QA feedback".
  • "A PR has a 'Testing Failed' label", "QA left comments saying features are broken".
  • "Trace the root cause of a QA-reported bug and fix it with scoped commits".
  • "Post a QA re-test comment after fixing the reported issues".

Not for: Writing new features or fresh code — use wp-github-flow. Setting up a CI pipeline from scratch — this skill triages failures in existing CI.

Overview

Full workflow for diagnosing and fixing bugs reported by QA on an open PR. Starts from the GitHub PR URL, ends with labels updated and a QA re-test comment posted.

Supporting files

  • scripts/fetch-pr-context.sh <pr> [owner/repo] — Step 1 in one command: prints

PR metadata, labels, and the full QA comment thread (newest last).

  • references/root-cause-patterns.md — catalog of recurring bug patterns

(symptom → cause → detect → fix). Read before tracing; append after.

  • references/qa-comment-template.md — the Step 8 re-test comment template + rules.
  • references/github-actions-wp-matrix.md — PHPUnit/PHPCS/PHPStan workflow configs, PHP×WP version matrix, caching, and CI failure triage.

Workflow

dot
digraph fix_qa {
    rankdir=TB;
    "Read PR + QA comments" -> "Checkout branch";
    "Checkout branch" -> "Trace root causes in code";
    "Trace root causes in code" -> "Fix scope-by-scope";
    "Fix scope-by-scope" -> "Lint / static analysis";
    "Lint / static analysis" -> "Commit each fix separately";
    "Commit each fix separately" -> "Push branch";
    "Push branch" -> "Update PR labels";
    "Update PR labels" -> "Post QA re-test comment";
}

Step 1 — Read PR and QA comments

bash
scripts/fetch-pr-context.sh <number> <owner/repo>

Or manually:

bash
gh pr view <number> --repo <owner/repo> \
  --json title,body,author,baseRefName,headRefName,state,labels
gh pr view <number> --repo <owner/repo> --json comments,reviews

Collect:

  • Which features QA says are broken (exact words) — read the latest QA comment; across re-fix rounds some features get confirmed fixed while others stay broken
  • Which features QA confirms work (do not regress these)
  • Label currently on the PR (Testing Failed, Need Testing, etc.)

Step 2 — Checkout the branch

bash
git fetch origin <branch>
git checkout <branch>

If the repo is not cloned locally, find it under wp-content/plugins/ or the relevant project path.

Step 3 — Trace root causes

Start from the action/hook/controller that handles the broken feature.

First, scan `references/root-cause-patterns.md` — most QA failures match a known pattern (array-cast-to-1, hook-fired-in-one-path, chart-renders-raw-id, duplicate-component-drift, default-margin-misalignment). It gives symptom → detect → fix for each.

Key questions when no known pattern matches:

  1. What hook/action fires this email / feature? Where is it fired

(grep -rn "do_action( 'hook'")? Is it reached on EVERY path to that state?

  1. Are any model get_*() returning wrong values after load() mutates state?
  2. (Frontend) Is a lib component rendering a raw key because no label/tooltip

render prop was passed? Does a sibling surface have a fix this one lacks?

When you trace a NEW non-obvious cause, append it to the catalog before moving on.

Step 4 — Fix scope-by-scope

One logical bug = one commit. Do not bundle unrelated fixes.

After each fix, verify the changed files:

bash
# PHP
vendor/bin/phpcs app/Models/ChangedFile.php

# JS/TS lint
yarn lint <files>

# Frontend changes: the build is the real proof (lint/tsc may be noisy)
yarn build          # or: node_modules/.bin/wp-scripts build

If the tooling env is broken (corepack lockfile error, eslintrc circular config, tsc halting on deprecations — all common on machines where global toolchain versions drifted from the lockfile), fall back to the local binary:

bash
node_modules/.bin/eslint <files>
node_modules/.bin/tsc --noEmit --ignoreDeprecations 6.0
node_modules/.bin/wp-scripts build

Separate pre-existing errors from yours. A noisy lint/tsc run (e.g. 60+ errors) is usually env/version mismatch, not your change. Confirm none of the errors reference your changed files. Pre-existing errors in unrelated files are OK to leave — only fix what your change introduced. The build compiling successfully is the strongest signal a frontend fix is sound.

A silent PHP check is a broken check, not a pass. When composer run lint, composer run analyze or composer run test prints nothing and exits 0, treat it as a failure to run — not as a clean result. PHP tools bootstrap through vendor/autoload.php, and if Composer's autoload.files eagerly loads a WordPress-guarded file:

php
defined( 'ABSPATH' ) || exit;

…then exit runs during autoload, outside WordPress. exit with no argument is status 0, so the tool dies before it analyses a single file and the shell reports success. Nothing distinguishes it from a real pass except the missing output.

Define the constant before the tool boots:

bash
printf '<?php define( "ABSPATH", "/path/to/wp/" );\n' > /tmp/abspath.php
php -d auto_prepend_file=/tmp/abspath.php vendor/bin/phpcs   <files>
php -d auto_prepend_file=/tmp/abspath.php vendor/bin/phpunit --filter MyTest
php -d auto_prepend_file=/tmp/abspath.php vendor/bin/phpstan analyse <path> --debug

PHPStan needs --debug here: its parallel workers re-bootstrap per process and die the same way, which surfaces as workers crashing rather than a clean result. --debug forces single-threaded analysis.

Prove the tool is live before trusting a clean run. A canary is faster than re-reading the config — feed it something that must fail:

bash
printf '<?php\n$x=1;\n if($x){echo "y";}\n' > /tmp/canary.php
php -d auto_prepend_file=/tmp/abspath.php vendor/bin/phpcs /tmp/canary.php
# Expect a wall of violations. Silence here means the tool is not running at all.

Same rule for PHPUnit: a run that reports OK (0 tests) or prints no summary line has not tested your change. Always cite the actual counts when claiming a pass.

On an already-red suite, diff names not totals. Where a suite has pre-existing failures, the totals shift on their own — a flaky test can mask a regression you introduced, or invent one you didn't. Capture the failing test names on both sides and diff those instead:

bash
run() { vendor/bin/phpunit 2>&1 | grep -E '^[0-9]+\) ' | sed 's/^[0-9]*) //' | sort; }
run > /tmp/after.txt
git stash -u && run > /tmp/before.txt && git stash pop
diff /tmp/before.txt /tmp/after.txt   # only additions matter

Lines added = regressions you own. Lines removed = tests you fixed, or flakes. Report it that way rather than as "N failures before, N after".

Step 5 — Commit each fix

bash
git add app/Path/To/ChangedFile.php
git commit -m "$(cat <<'EOF'
fix(scope): short imperative summary

Root cause: <what was actually wrong>
Fix: <what was changed and why>
EOF
)"

Use fix(scope): prefix. Scope = the subsystem (referral, transaction, email, spa, etc.).

Before committing built assets: check whether build/ (or dist/) is tracked or ignored, and match the repo's convention — don't commit generated output if prior PR commits were source-only:

bash
git check-ignore build/        # prints "build/" if ignored → commit source only
git show --stat <prev-commit>  # confirm what prior fix commits included

Step 6 — Push

bash
git push origin <branch>

No new PR needed if the branch already has an open PR — the new commits update it automatically.

Step 7 — Update labels

Only swap if the current label is wrong for re-test. If the PR is already Need Testing (a re-fix round on a still-open testing cycle), leave it — no change needed. Swap only when moving off a terminal state:

bash
# See available labels first
gh label list --repo <owner/repo>

# Only if currently "Testing Failed"/"Testing Ongoing":
gh pr edit <number> --repo <owner/repo> \
  --remove-label "Testing Failed" \
  --add-label "Need Testing"

Step 8 — Post QA re-test comment

Use references/qa-comment-template.md. Comment must include all four:

SectionContent
Summary tableEach broken feature → root cause → fix (1 line each)
Step-by-step test instructionsNumbered steps per feature, specific UI path
Regression checkAsk QA to re-verify previously working items
Commit SHAsLatest fix commits so QA knows what to test against
bash
gh pr comment <number> --repo <owner/repo> --body "$(cat <<'EOF'
<filled-in template from references/qa-comment-template.md>
EOF
)"

Common Mistakes

MistakeFix
Bundling multiple bug fixes in one commitOne logical fix per commit — easier to revert and for QA to trace
Ignoring pre-existing lint errorsOnly fix errors your changes introduced
Opening a new PR when branch already has oneJust push; the existing PR updates automatically
Vague QA comment ("fixed bugs")Name each broken feature, give exact UI steps
Forgetting regression check in QA commentAlways ask QA to confirm previously passing items still pass
Not verifying do_action call sitesCheck ALL places a hook should fire, not just the obvious one
Skipping build on frontend PRsLint/tsc may be broken or noisy; yarn build compiling is the real proof
Treating noisy lint/tsc as your fault60+ errors = env/version drift. Confirm none name your files, then proceed
Reading "no output, exit 0" from a PHP check as a passAn ABSPATH-guarded autoload file exits with status 0 before the tool runs. Re-run under auto_prepend_file and confirm with a canary
Claiming tests pass without citing countsOK (0 tests) and a crashed bootstrap both look like success. Quote the summary line
Comparing a red suite by eyeballing totalsFlaky tests move the count either way. Diff the failing test names before and after
Committing gitignored build/ outputCheck git check-ignore build/; match prior commits (usually source-only)
Swapping a label that's already correctIf already Need Testing on a re-fix round, leave it
Reading only the first QA commentRead the latest — features confirmed fixed in round 1 shouldn't be re-touched
同じリポジトリから

関連する Skills

すべての Skills
mralaminahamed
コミュニティ

wp-admin-browser

Use when a WordPress admin panel needs real browser interaction via Chrome DevTools MCP — logging in, navigating admin menus, clicking buttons, filling and submitting forms, creating/editing/deleting content through the UI, creating a temporary test admin user, verifying JS state or localStorage, capturing screenshots, or obtaining a REST nonce via admin-ajax.php. Triggers: \"open WP admin\", \"log in to WordPress\", \"navigate to Settings\", \"create a test user in admin\", \"click Save Changes

1時間の導入数
1
GitHub Stars
29
更新日
7月20日
mralaminahamed
コミュニティ

wp-build-tools

Use when setting up, configuring, or debugging the JavaScript/CSS build pipeline for a WordPress plugin — @wordpress/scripts, webpack (webpack.config.js, entry points, externals), Vite, block editor asset compilation with block.json, enqueueing built assets with .asset.php dependency files, wpenqueuescript / wplocalizescript, Sass/SCSS/PostCSS compilation, TypeScript support, registerblocktype, or reusing a JS/CSS library already bundled by a host plugin (EDD, WooCommerce, Elementor). Triggers:

1時間の導入数
1
GitHub Stars
29
更新日
7月20日
mralaminahamed
コミュニティ

wp-org-submission

Use when submitting a WordPress plugin to the WP.org directory for the first time, deploying a new version via SVN (plugins.svn.wordpress.org trunk, tags, assets), fixing a reviewer rejection (17-issue catalog with exact reviewer quotes), writing or correcting readme.txt (Stable tag, Changelog, Upgrade Notice, Requires, Tested up to, External services), or preparing WP.org assets (banner-772x250.png, banner-1544x500.png, icon-128x128.png, icon-256x256.png, icon.svg, screenshot-N.png). Triggers:

1時間の導入数
1
GitHub Stars
29
更新日
7月20日