majesticlabs-dev/majestic-marketplace

pr-comment-resolver

Address PR review comments by implementing reviewer feedback and suggestions.

소스 보기

사용 방법

  1. 설치 명령을 복사하고 자신의 에이전트 환경에 설치하기 전에 소스 패키지를 확인하세요.
  2. 필요한 도구, 인증 정보, 지원 환경은 원본 문서에서 확인하세요.
  3. 입력과 원하는 산출물을 설명하고 출처와 결과를 대조하세요.
npx skills add https://github.com/majesticlabs-dev/majestic-marketplace --skill pr-comment-resolver

시작 전 확인

  • 설치에는 모델 구독, API 한도, 파일 접근 권한이 포함되지 않습니다.
  • 별점 수와 설치 수는 활동 지표이며 독립적인 품질·보안 검증이 아닙니다.
원본 Skill 문서

원본 저장소의 제목, 예시, 코드, 표, 링크, 이미지를 유지해 표시합니다.

PR Comment Resolver

Audience: Developers with PR review comments that need resolution.

Goal: Understand reviewer feedback, implement changes, verify fixes.

PR Comment Commands

bash
# List all PR comments
gh pr view <PR_NUMBER> --comments

# Get review comments on files
gh api repos/{owner}/{repo}/pulls/{pr_number}/comments

# Get specific review details
gh api repos/{owner}/{repo}/pulls/{pr_number}/reviews

Comment Types

TypeIndicatorsAction
Bug fix"This will break...", "Missing check..."Implement the fix
Refactor"Extract this...", "This is too complex..."Apply the pattern
Style"Rename to...", "Format as..."Adjust naming/format
Tests"Add test for...", "Missing coverage..."Add test cases
Docs"Add comment...", "Document this..."Add documentation
Questions"Why...?", "What about...?"Reply with explanation

Workflow

  1. Read - Get comment content and context
  2. Locate - Find the code being discussed
  3. Understand - Note constraints/preferences
  4. Implement - Make requested changes
  5. Verify - Run tests if code changed
  6. Report - Summarize resolution

Implementation Principles

  • Address the specific feedback
  • Maintain existing code style
  • Don't break other functionality
  • Follow project conventions
  • Ask if feedback is ambiguous

Resolution Report

PR Comment Resolution

Comment: "[Quote or summary of feedback]"
   Location: `file:line`

Changes:
- `path/to/file`: [Change description]
- `path/to/test`: [Test updates if any]

Resolution:
[How changes address the feedback]

Verified:
- [Tests run, if applicable]

Notes:
[Any context for reviewer]

Example Resolutions

Refactoring Request

PR Comment Resolution

Comment: "This function is too complex, please extract validation"
   Location: `app/services/order.py:45`

Changes:
- `app/services/order.py`: Extracted to `_validate_items()`
- `tests/test_order.py`: Added tests for new method

Resolution:
Split 25-line method into two focused functions with single responsibility.

Verified:
- `pytest tests/test_order.py` - all passing

Missing Test Coverage

PR Comment Resolution

Comment: "Add test for the edge case when list is empty"
   Location: `src/utils/helpers.ts:23`

Changes:
- `tests/utils/helpers.test.ts`: Added empty array test case

Resolution:
Added test that verifies graceful handling of empty input.

Verified:
- `npm test -- helpers` - all passing

When Blocked

If comment is unclear or conflicting:

  1. State your interpretation
  2. Explain any constraints
  3. Suggest alternatives if needed
  4. Ask for clarification
같은 저장소의 Skills

더 많은 Skills

모든 Skills