helderberto/agent-skills

code-review

Review a GitHub PR for bugs, security, performance, and code quality.

查看源码

使用方法

  1. 复制安装命令,在自己的智能体环境安装前先检查源码包。
  2. 从原始文档核对所需工具、凭据和支持的宿主。
  3. 说明输入材料与期望交付物,并对照来源检查输出。
npx skills add https://github.com/helderberto/agent-skills --skill code-review

开始前需了解

  • 安装不包含模型订阅、API 额度或访问文件的权限。
  • 仓库星数和安装量反映活跃情况,不等于独立质量或安全测试。
仓库原始内容

按源仓库内容呈现,保留标题、案例、代码、表格、链接以及原文引用的演示图片。

Review Pull Request

Mode: $ARGUMENTS — BUGS, SECURITY, or PERFORMANCE narrows the review to that axis; otherwise apply all.

Approval standard

Approve when the change definitely improves overall code health, even if it isn't perfect. Don't block a change because it isn't how you would have written it. If it improves the codebase and follows its conventions, approve.

If the change is too large to review well (~1000+ lines), asking the author to split it is a valid outcome. Suggest a strategy: stack (small change, next one based on it), by file group, horizontal (shared code first, then consumers), or vertical (one end-to-end slice per PR).

Review criteria

Review every changed file, not just the latest commit.

  • Correctness: logic bugs, off-by-ones, race conditions, unhandled states, missing error paths
  • Readability: functions > 50 lines, nesting > 2 levels, dead code, unused imports
  • Security: exposed secrets, unvalidated external data
  • Type safety & immutability: any or unjustified assertions; in-place mutation of shared data
  • Patterns: consistent with codebase conventions, no reinvented wheels
  • Performance: unnecessary re-renders, O(n²) where O(n) works
  • Code smells: match the diff against the baseline in smells.md — always judgement calls; the repo's documented style overrides the baseline
  • Dependency upgrades (manifest/lockfile in the diff): one dependency per change — a bulk bump that breaks hides which package did it; verify against the changelog, not the version number; review the lockfile diff (one direct bump pulls dozens of transitive changes); flag hand-edited lockfiles

Output

Group by severity, file:line on every finding, a suggested fix for every Critical:

  • Critical — must fix before merge (bugs, vulnerabilities)
  • Suggestions — improvements worth considering
  • Nit — minor and optional; label true nitpicks as Nit rather than dropping or inflating them
  • FYI — informational
  • Positives — good patterns to call out

One structural problem and ten nits: the structural problem is the review — lead with it. Close with the verdict against the approval standard.

按任务相关推荐

来自同一仓库

更多 Skills

全部 Skills
helderberto
社区

codebase-design

Shared vocabulary for designing deep modules. Use when designing or improving a module's interface, placing a seam, making code more testable, or when another skill needs it. Don't use for codebase-wide audits (/architecture-audit) or UI components (/frontend-ui-engineering).

1小时安装量
1
GitHub Stars
17
最近更新
10月19日
helderberto
社区

debug

Disciplined diagnosis loop for hard bugs and performance regressions. Use when user says "diagnose" or "debug this", or reports something broken, throwing, failing, or slow. Don't use to build a feature or fix an understood bug test-first (/tdd).

1小时安装量
1
GitHub Stars
17
最近更新
10月19日
helderberto
社区

deps-audit

Check dependencies for known vulnerabilities and staleness. Use when asked to "audit dependencies", "check for vulnerabilities", or check dependency health. Don't use for code quality review.

1小时安装量
1
GitHub Stars
17
最近更新
10月19日
helderberto
社区

frontend-ui-engineering

Front-load UI construction decisions — component boundary and prop API, state placement, required states, responsiveness, accessibility. Use when creating or refactoring a component, page, or design-system primitive. Don't use for pure logic (/tdd), throwaway exploration (/prototype), or auditing finished UI (/a11y-audit).

1小时安装量
1
GitHub Stars
17
最近更新
10月19日