alexbruno/dev-skills

code-review

Perform structured, multi-dimensional code reviews aligned with the spec-driven-workflow (workflow/SPEC.md, workflow/PLAN.md, workflow/REVIEW.md).

ソースを見る

使い方

  1. インストールコマンドをコピーし、自分の環境へ導入する前にソースを確認します。
  2. 必要なツール、認証情報、対応環境を原文で確認します。
  3. 入力と成果物を指定し、出力を資料と照合します。
npx skills add https://github.com/alexbruno/dev-skills --skill code-review

開始前の確認

  • 導入にはモデル契約、API枠、ファイルへのアクセス許可は含まれません。
  • スター数や導入数は活動の指標であり、独立した品質・安全性試験ではありません。
リポジトリの原文

見出し、例、コード、表、リンク、参照画像を含む原文を表示しています。

Code Review

Review code changes against both engineering quality and specification intent, recording every actionable finding in workflow/REVIEW.md.

Review Philosophy

  • Net improvement over perfection: Approve changes that clearly improve overall code health and satisfy workflow/SPEC.md, even if minor stylistic preferences differ.
  • Evidence over opinion: Ground every finding in a concrete file path, line range or symbol, and explain why it matters.
  • Zero silent passes: Do not approve or finish work while any blocker or major finding remains open.

1. Load Workflow Context First

Before inspecting the diff, read the active workflow/ artifacts (or workflow/<change-slug>/ for scoped parallel work):

  1. `workflow/SPEC.md` — Verify goals, non-goals, constraints, and acceptance criteria.
  2. `workflow/PLAN.md` (and `workflow/TASKS.md`, if present) — Understand the intended technical approach and module scope.
  3. `workflow/REVIEW.md` — Check prior review rounds so resolved items are not re-reported and open items are re-verified.

If workflow/REVIEW.md does not exist yet, create it (using the spec-driven-workflow REVIEW.md template if installed).

2. Five-Axis Review Framework

Evaluate the diff (e.g., git diff, staged changes, or target PR) across all five dimensions:

  1. Correctness & Spec Alignment
  • Does the implementation satisfy every acceptance criterion in workflow/SPEC.md?
  • Does it stay within scope (no unintended changes outside SPEC.md / PLAN.md)?
  • Are edge cases (null/empty values, boundaries, concurrency) and error paths handled?
  • Do tests verify the new behavior and guard against regressions?
  1. Readability & Simplicity
  • Are names clear and consistent with the codebase?
  • Is control flow shallow and easy to follow without dead code or over-engineering?
  1. Architecture & Maintainability
  • Does the change follow existing codebase patterns and respect module boundaries?
  • Does it avoid duplicated logic or unnecessary coupling?
  1. Security
  • Is untrusted input validated and sanitized at system boundaries?
  • Are secrets, tokens, and sensitive data kept out of code, configs, and logs?
  • Are queries parameterized and auth/authorization checks enforced?
  1. Performance
  • Are there obvious N+1 queries, unbounded loops/fetches, memory leaks, or blocking I/O on hot paths?

3. Record Findings in workflow/REVIEW.md

Log every finding in workflow/REVIEW.md using consistent severity tiers and resolution statuses:

  • Severities:
  • blocker: Must be fixed before completion (broken spec requirement, security flaw, data-loss risk, failing build/tests).
  • major: Must be addressed before completion (edge-case bug, weak error handling, architectural violation, missing test coverage).
  • minor: Optional improvement or nit (naming, minor readability cleanup); never blocks approval.
  • question: Clarification needed from the author or implementing agent.
  • Statuses: open | resolved | wontfix (with brief rationale).

Each finding entry must include:

  • A unique ID (e.g., [R1], [Q1]), exact file path and line/symbol reference, severity, status, Issue, and Action.

4. Verification & Sign-Off

  1. Run the project's verification commands (test, lint, typecheck, build as applicable) rather than relying on inspection alone.
  2. Update workflow/REVIEW.md status (Open | Changes Requested | Approved):
  • Approved: All SPEC.md acceptance criteria are met, checks pass, and zero blocker or major items remain open.
  • Changes Requested: One or more blocker or major items remain open.
  1. Follow the spec-driven-workflow cleanup rule: never delete workflow/REVIEW.md; only clear/reset its contents after the user confirms everything is ready.
同じリポジトリから

関連する Skills

すべての Skills
alexbruno
コミュニティ

architect-worker

Role-based multi-agent software engineering pattern separating high-level architecture, specification, planning, and code review (Architect) from focused code implementation and verification (Worker). Use this skill whenever assigned the Architect or Worker role (in any language), or when coordinating work between planning/review agents and implementation agents via workflow/.

1時間の導入数
1
GitHub Stars
0
更新日
11月13日
alexbruno
コミュニティ

changelog-management

Maintain and update a standardized root CHANGELOG.md following Keep a Changelog and Semantic Versioning. Use this skill to initialize or update changelog entries, categorize changes, prepare release cuts, and proactively prompt the user when notable changes warrant updating the changelog.

1時間の導入数
1
GitHub Stars
0
更新日
11月13日
alexbruno
コミュニティ

code-simplification

Simplify code for human readability, clarity, and directness without changing behavior. Use this skill after implementing a feature, during refactoring, or when addressing code review feedback—especially when code feels over-engineered, deeply nested, or takes unnecessary detours to do simple things.

1時間の導入数
1
GitHub Stars
0
更新日
11月13日
alexbruno
コミュニティ

codebase-indexing

Index, synchronize, and query a project's codebase using CodeGraph and Repomix. Use this skill when exploring an unfamiliar repository, maintaining up-to-date code intelligence after edits, or setting up project indexing with .codegraph/ and Markdown-formatted Repomix snapshots.

1時間の導入数
1
GitHub Stars
0
更新日
11月13日