사용 방법
- 설치 명령을 복사하고 자신의 에이전트 환경에 설치하기 전에 소스 패키지를 확인하세요.
- 필요한 도구, 인증 정보, 지원 환경은 원본 문서에서 확인하세요.
- 입력과 원하는 산출물을 설명하고 출처와 결과를 대조하세요.
npx skills add https://github.com/alexbruno/dev-skills --skill code-review시작 전 확인
- 설치에는 모델 구독, API 한도, 파일 접근 권한이 포함되지 않습니다.
- 별점 수와 설치 수는 활동 지표이며 독립적인 품질·보안 검증이 아닙니다.
원본 저장소의 제목, 예시, 코드, 표, 링크, 이미지를 유지해 표시합니다.
Code Review
Review code changes against both engineering quality and specification intent, recording every actionable finding in workflow/REVIEW.md.
Review Philosophy
- Net improvement over perfection: Approve changes that clearly improve overall code health and satisfy
workflow/SPEC.md, even if minor stylistic preferences differ. - Evidence over opinion: Ground every finding in a concrete file path, line range or symbol, and explain why it matters.
- Zero silent passes: Do not approve or finish work while any
blockerormajorfinding remainsopen.
1. Load Workflow Context First
Before inspecting the diff, read the active workflow/ artifacts (or workflow/<change-slug>/ for scoped parallel work):
- `workflow/SPEC.md` — Verify goals, non-goals, constraints, and acceptance criteria.
- `workflow/PLAN.md` (and `workflow/TASKS.md`, if present) — Understand the intended technical approach and module scope.
- `workflow/REVIEW.md` — Check prior review rounds so resolved items are not re-reported and open items are re-verified.
If workflow/REVIEW.md does not exist yet, create it (using the spec-driven-workflow REVIEW.md template if installed).
2. Five-Axis Review Framework
Evaluate the diff (e.g., git diff, staged changes, or target PR) across all five dimensions:
- Correctness & Spec Alignment
- Does the implementation satisfy every acceptance criterion in
workflow/SPEC.md? - Does it stay within scope (no unintended changes outside
SPEC.md/PLAN.md)? - Are edge cases (null/empty values, boundaries, concurrency) and error paths handled?
- Do tests verify the new behavior and guard against regressions?
- Readability & Simplicity
- Are names clear and consistent with the codebase?
- Is control flow shallow and easy to follow without dead code or over-engineering?
- Architecture & Maintainability
- Does the change follow existing codebase patterns and respect module boundaries?
- Does it avoid duplicated logic or unnecessary coupling?
- Security
- Is untrusted input validated and sanitized at system boundaries?
- Are secrets, tokens, and sensitive data kept out of code, configs, and logs?
- Are queries parameterized and auth/authorization checks enforced?
- Performance
- Are there obvious N+1 queries, unbounded loops/fetches, memory leaks, or blocking I/O on hot paths?
3. Record Findings in workflow/REVIEW.md
Log every finding in workflow/REVIEW.md using consistent severity tiers and resolution statuses:
- Severities:
blocker: Must be fixed before completion (broken spec requirement, security flaw, data-loss risk, failing build/tests).major: Must be addressed before completion (edge-case bug, weak error handling, architectural violation, missing test coverage).minor: Optional improvement or nit (naming, minor readability cleanup); never blocks approval.question: Clarification needed from the author or implementing agent.- Statuses:
open|resolved|wontfix(with brief rationale).
Each finding entry must include:
- A unique ID (e.g.,
[R1],[Q1]), exact file path and line/symbol reference, severity, status, Issue, and Action.
4. Verification & Sign-Off
- Run the project's verification commands (
test,lint,typecheck,buildas applicable) rather than relying on inspection alone. - Update
workflow/REVIEW.mdstatus (Open|Changes Requested|Approved):
- Approved: All
SPEC.mdacceptance criteria are met, checks pass, and zeroblockerormajoritems remainopen. - Changes Requested: One or more
blockerormajoritems remainopen.
- Follow the
spec-driven-workflowcleanup rule: never deleteworkflow/REVIEW.md; only clear/reset its contents after the user confirms everything is ready.