majesticlabs-dev/majestic-marketplace

pragmatic-rails-reviewer

Review Rails code with high quality bar.

소스 보기

사용 방법

  1. 설치 명령을 복사하고 자신의 에이전트 환경에 설치하기 전에 소스 패키지를 확인하세요.
  2. 필요한 도구, 인증 정보, 지원 환경은 원본 문서에서 확인하세요.
  3. 입력과 원하는 산출물을 설명하고 출처와 결과를 대조하세요.
npx skills add https://github.com/majesticlabs-dev/majestic-marketplace --skill pragmatic-rails-reviewer

시작 전 확인

  • 설치에는 모델 구독, API 한도, 파일 접근 권한이 포함되지 않습니다.
  • 별점 수와 설치 수는 활동 지표이며 독립적인 품질·보안 검증이 아닙니다.
원본 Skill 문서

원본 저장소의 제목, 예시, 코드, 표, 링크, 이미지를 유지해 표시합니다.

Pragmatic Rails Code Review

Audience: Rails developers reviewing code changes Goal: High quality bar -- strict for modifications to existing code, pragmatic for new isolated code

Skills

Reference rails-conventions for pattern enforcement.

Review Approach

Existing Code Modifications - BE STRICT

  • Any added complexity needs strong justification
  • Prefer extracting to new controllers over complicating existing
  • Question: "Does this make existing code harder to understand?"
  • Check for regressions: Was functionality accidentally broken?

New Isolated Code - BE PRAGMATIC

  • If isolated and works, it's acceptable
  • Flag obvious improvements but don't block progress
  • Focus on testability and maintainability

Critical Checks

Deletions & Regressions

For each deletion, verify:

  • Was this intentional for THIS feature?
  • Does removing this break existing workflows?
  • Are there tests that will fail?
  • Is logic moved elsewhere or completely removed?

Convention Violations

Apply rails-conventions patterns:

  • Turbo streams inline vs separate files
  • Controller complexity
  • Service extraction signals
  • Scope patterns
  • Enum patterns

Output Format

markdown
## Critical Issues
[Blocking: regressions, breaking changes, security]

## Convention Violations
[Rails pattern violations from rails-conventions]

## Suggestions
[Optional improvements, not blocking]

## Summary
[APPROVED / NEEDS CHANGES]

Be thorough but actionable. Explain WHY and provide specific fix examples.

관련 작업

같은 저장소의 Skills

더 많은 Skills

모든 Skills