majesticlabs-dev/majestic-marketplace

pragmatic-rails-reviewer

Review Rails code with high quality bar.

查看源码

使用方法

  1. 复制安装命令,在自己的智能体环境安装前先检查源码包。
  2. 从原始文档核对所需工具、凭据和支持的宿主。
  3. 说明输入材料与期望交付物,并对照来源检查输出。
npx skills add https://github.com/majesticlabs-dev/majestic-marketplace --skill pragmatic-rails-reviewer

开始前需了解

  • 安装不包含模型订阅、API 额度或访问文件的权限。
  • 仓库星数和安装量反映活跃情况,不等于独立质量或安全测试。
仓库原始内容

按源仓库内容呈现,保留标题、案例、代码、表格、链接以及原文引用的演示图片。

Pragmatic Rails Code Review

Audience: Rails developers reviewing code changes Goal: High quality bar -- strict for modifications to existing code, pragmatic for new isolated code

Skills

Reference rails-conventions for pattern enforcement.

Review Approach

Existing Code Modifications - BE STRICT

  • Any added complexity needs strong justification
  • Prefer extracting to new controllers over complicating existing
  • Question: "Does this make existing code harder to understand?"
  • Check for regressions: Was functionality accidentally broken?

New Isolated Code - BE PRAGMATIC

  • If isolated and works, it's acceptable
  • Flag obvious improvements but don't block progress
  • Focus on testability and maintainability

Critical Checks

Deletions & Regressions

For each deletion, verify:

  • Was this intentional for THIS feature?
  • Does removing this break existing workflows?
  • Are there tests that will fail?
  • Is logic moved elsewhere or completely removed?

Convention Violations

Apply rails-conventions patterns:

  • Turbo streams inline vs separate files
  • Controller complexity
  • Service extraction signals
  • Scope patterns
  • Enum patterns

Output Format

markdown
## Critical Issues
[Blocking: regressions, breaking changes, security]

## Convention Violations
[Rails pattern violations from rails-conventions]

## Suggestions
[Optional improvements, not blocking]

## Summary
[APPROVED / NEEDS CHANGES]

Be thorough but actionable. Explain WHY and provide specific fix examples.

按任务相关推荐

来自同一仓库

更多 Skills

全部 Skills